Expression aesthetics #6685
Merged
Expression aesthetics #6685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teunbrand
commented
Oct 7, 2025
| labels <- lapply(labels, `[`, i) | ||
| } | ||
| if (is.expression(label)) { | ||
| label <- unclass(as.list(label)) |
There was a problem hiding this comment.
The unclass() idea is from #6639.
It counters length 1 expression subclasses, which is admittedly a niche problem.
thomasp85
approved these changes
Oct 20, 2025
|
I think there is a small bug but otherwise LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #6622 and fix #6638.
Essentially, whenever an expression
labelcomes in, we pack it as a list. In the drawing methods ofGeomTextandGeomLabelwe unpack the list back to expressions. This way, expressions survive internals.